Skip to content

name swarm container, add consul to mavis#224

Merged
bkendall merged 3 commits intomasterfrom
mavis-with-consul
Dec 7, 2015
Merged

name swarm container, add consul to mavis#224
bkendall merged 3 commits intomasterfrom
mavis-with-consul

Conversation

@anandkumarpatel
Copy link
Copy Markdown

  • name swarm container so mavis can access it
  • add consul to mavis since now it needs to talk to consul
  • add docker_client since mavis now needs to talk to the docks

reviewers

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we running tests for mavis against this new version pair?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep :)

@und1sk0
Copy link
Copy Markdown
Contributor

und1sk0 commented Dec 7, 2015

Clearly would prefer getting the private key file out of GH, but otherwise seems reasonable.

@podviaznikov
Copy link
Copy Markdown
Member

tested on beta 👍

bkendall added a commit that referenced this pull request Dec 7, 2015
name swarm container, add consul to mavis
@bkendall bkendall merged commit e88780b into master Dec 7, 2015
@bkendall bkendall deleted the mavis-with-consul branch December 7, 2015 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants